tqchen commented on PR #399: URL: https://github.com/apache/tvm-ffi/pull/399#issuecomment-3801227235
Thanks @guan404ming , i think we are close, i have one behavior comment. Besides that, given this is new public API, i think it would be helpful to do a round of quick API review, can you provide a list of APIs(including methods), would be good to categorize them as: - C0: strictly follows c++ standard - C1: others and list rationale(e.g. we follows rust API) Would also be good to discuss move and value copy behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
