gemini-code-assist[bot] commented on code in PR #18691:
URL: https://github.com/apache/tvm/pull/18691#discussion_r2735988374
##########
tests/python/relax/test_frontend_onnx.py:
##########
@@ -2678,27 +2679,51 @@ def _generate_roi_cases():
[0.1, 0.2, 0.9, 0.8],
]
for roi in roi_cases:
- roi_list.append(pytest.param(True, roi, id=f"roi_{'_'.join(str(x) for
x in roi)}"))
+ roi_list.append(pytest.param(True, roi, True,
id=f"roi_{'_'.join(str(x) for x in roi)}"))
+ roi_list.append(pytest.param(True, roi, False,
id=f"roi_{'_'.join(str(x) for x in roi)}"))
Review Comment:
The `pytest.param` calls inside this loop generate duplicate test IDs. For
example, when `roi` is `[]`, both calls will have `id="roi_"`. This can cause
issues with test discovery and reporting. To ensure unique test IDs, you should
include information about whether `roi` is a constant or an initializer in the
ID string.
```suggestion
roi_list.append(pytest.param(True, roi, True,
id=f"const_roi_{'_'.join(str(x) for x in roi)}"))
roi_list.append(pytest.param(True, roi, False,
id=f"initializer_roi_{'_'.join(str(x) for x in roi)}"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
