Seven-Streams commented on PR #399: URL: https://github.com/apache/tvm-ffi/pull/399#issuecomment-3823401134
Currently, in XGrammar's result library, [`ResultOk(...)` and `ResultErr(...)`](https://github.com/Ubospica/xgrammar/blob/15dc61d02ed24820215ca1d491d6a07ba32fff50/cpp/support/utils.h#L124-L212) are used to return success or error values, and I think it is easy to use. In addition, I also agree that implicit conversion is a good choice, since it follows [the examples in cppreference](https://en.cppreference.com/w/cpp/utility/expected.html) well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
