tqchen opened a new pull request, #425: URL: https://github.com/apache/tvm-ffi/pull/425
Previously we relied on a special error to handle EnvErrorAlreadySet, this PR updates the behavior so that the Error being thrown can also have kind EnvErrorAlreadySet, which indicate there is an interrupt. This allows the error handling behavior to be overall simpler and more consistent, removing boliler plate in C++ exposure. ABI impact: this change only impacts the downstream c++ usage that uses EnvErrorAlreadySet. The downstream DSLs and libraries are not impacted by this change. The only usecase so far is tvm compiler autotuning service to propagate KeyboardInterrupt. Given the benefit and limited impact, we could consider bring it in, since it simplifies the checking and throw logics in the function and further streamlines error handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
