tqchen commented on code in PR #18700:
URL: https://github.com/apache/tvm/pull/18700#discussion_r2758974886
##########
CMakeLists.txt:
##########
@@ -670,7 +670,18 @@ if(GTEST_FOUND)
if(DEFINED LLVM_SO OR HIDE_PRIVATE_SYMBOLS)
target_link_libraries(cpptest PRIVATE ${LLVM_LIBS})
endif()
+
+ # Ensure we link terminfo when required by LLVM / libedit at link time.
+ find_package(Curses)
+ if(CURSES_FOUND)
+ message(STATUS "Found Curses/terminfo library: ${CURSES_LIBRARIES}")
Review Comment:
i think llvm only requires tinfo but not curses library? we do want to avoid
dependency bloat in this case
##########
CMakeLists.txt:
##########
@@ -670,7 +670,18 @@ if(GTEST_FOUND)
if(DEFINED LLVM_SO OR HIDE_PRIVATE_SYMBOLS)
target_link_libraries(cpptest PRIVATE ${LLVM_LIBS})
endif()
+
+ # Ensure we link terminfo when required by LLVM / libedit at link time.
+ find_package(Curses)
+ if(CURSES_FOUND)
+ message(STATUS "Found Curses/terminfo library: ${CURSES_LIBRARIES}")
Review Comment:
The dependency should also be specified and captured through llvm config in
findllm instead of here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
