gemini-code-assist[bot] commented on PR #427: URL: https://github.com/apache/tvm-ffi/pull/427#issuecomment-3852425719
## Summary of Changes Hello @junrushao, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly reorganizes and enhances the documentation for the `tvm-ffi-stubgen` tool. It extracts the comprehensive guide for generating Python type stubs from C++ reflection metadata into a new, standalone document, improving clarity and discoverability. The previous, less detailed section within the Python packaging documentation has been streamlined to provide a high-level overview and direct users to the new dedicated resource. Additionally, documentation build configurations are adjusted to refine the generated output. ### Highlights * **New Dedicated Documentation**: A comprehensive, standalone documentation page for the `tvm-ffi-stubgen` tool has been added, detailing its usage, configuration, and advanced features. * **Documentation Refactoring**: The detailed stub generation content previously embedded within `python_packaging.rst` has been moved to the new `stubgen.rst` file, with the original section now providing a concise overview and a link to the dedicated guide. * **Documentation Build Configuration Update**: The `conf.py` file has been updated to exclude specific internal FFI macros and patterns from the generated documentation, ensuring cleaner and more focused API references. * **URL Update**: Internal links and constants pointing to the stub generation documentation have been updated to reflect the new, dedicated page. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **docs/conf.py** * Added `TVM_FFI_LOG_EXCEPTION_CALL_BEGIN`, `TVM_FFI_LOG_EXCEPTION_CALL_END`, `TVM_FFI_CLEAR_PTR_PADDING_IN_FFI_ANY`, `TVM_FFI_STATIC_INIT_BLOCK`, `TVM_FFI_STATIC_INIT_BLOCK_DEF_`, and `TVM_FFI_DEFINE_DEFAULT_COPY_MOVE_AND_ASSIGN` to `EXCLUDE_SYMBOLS`. * Added `*internal*` to `EXCLUDE_PATTERNS`. * **docs/index.rst** * Included `packaging/stubgen.rst` in the table of contents under the 'Packaging' section. * **docs/packaging/python_packaging.rst** * Removed the extensive 'Stub Generation Tool' and 'Other Directives' sections. * Replaced the removed content with a brief introduction to `tvm-ffi-stubgen` and a `seealso` link to the new `stubgen.rst` documentation. * **docs/packaging/stubgen.rst** * Added a new, comprehensive documentation file for 'Stub Generation'. * Detailed sections include CMake-based generation, CLI-based generation, and a full reference for inline directives (`global/<prefix>`, `object/<type_key>`, `import-section`, `export/<module>`, `__all__`, `ty-map`, `import-object`, `skip-file`). * **python/tvm_ffi/stub/consts.py** * Updated `DOC_URL` to point to the new `https://tvm.apache.org/ffi/packaging/stubgen.html`. </details> <details> <summary><b>Activity</b></summary> * No specific activity (comments, reviews, etc.) has been recorded for this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
