gemini-code-assist[bot] commented on PR #432: URL: https://github.com/apache/tvm-ffi/pull/432#issuecomment-3863706161
## Summary of Changes Hello @junrushao, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request orchestrates a significant shift in the project's Python development workflow by replacing `mypy` with `ty` as the primary type checker. This move is driven by the desire to leverage `ty`'s enhanced performance and precision in type analysis. The changes encompass updates to the project's development environment setup, pre-commit automation, and the codebase itself, where type annotations and ignore directives have been adjusted to conform with the new type checker's expectations. ### Highlights * **Type Checker Migration**: The project has transitioned its Python type checking from `mypy` to `ty`, a modern type checker and LSP from Astral, known for its speed and accuracy. * **Pre-commit Hook Update**: The `.pre-commit-config.yaml` has been updated to remove the `mypy` hook and integrate `ty` as a local pre-commit check using `uvx ty check`. * **Dependency and Configuration Changes**: The `pyproject.toml` file now lists `ty` instead of `mypy` in development dependencies, and the `[tool.mypy]` configuration has been replaced with a new `[tool.ty]` section, including specific environment, source, and analysis settings. * **Refinement of Type Ignores**: Numerous `type: ignore` comments across the codebase have been removed or updated to `ty: ignore` directives, reflecting `ty`'s different or improved type inference capabilities. * **Documentation Alignment**: The `CONTRIBUTING.md` file has been updated to inform contributors about the switch to `ty` for Python type annotations. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **.pre-commit-config.yaml** * Removed `mypy` pre-commit hook configuration. * Added `ty` as a local pre-commit hook, configured to run `uvx ty check`. * **CONTRIBUTING.md** * Updated documentation to reflect the use of `ty` for Python type checking. * **examples/cubin_launcher/benchmark_overhead.py** * Removed `type: ignore[import-not-found]` comments for `triton` imports. * **examples/cubin_launcher/example_triton_cubin.py** * Removed `type: ignore[import-not-found]` comments for `triton` imports. * **pyproject.toml** * Replaced `mypy` with `ty` in the `[dependency-groups].dev` section. * Removed the `[tool.mypy]` configuration block. * Added a new `[tool.ty]` configuration block with environment, source, and analysis settings, including `allowed-unresolved-imports`. * **python/tvm_ffi/__init__.py** * Removed `type: ignore` from `import torch` statement. * Removed `type: ignore[import-not-found]` from `_version` import. * **python/tvm_ffi/_convert.py** * Refactored `torch` import to explicitly set `torch = None` on `ImportError` and removed `type: ignore[no-redef]`. * **python/tvm_ffi/_optional_torch_c_dlpack.py** * Removed `type: ignore` from `logger` initialization. * Removed `type: ignore` from `torch_c_dlpack_ext` import. * **python/tvm_ffi/_tensor.py** * Updated `type: ignore[arg-type]` to `ty: ignore[invalid-argument-type]` for `tuple.__new__`. * Removed `type: ignore[attr-defined]` for `_tvm_ffi_cached_object` assignment. * **python/tvm_ffi/container.py** * Added `ty: ignore[invalid-method-override]` to `__getitem__` and `__contains__` methods. * Added `ty: ignore[invalid-argument-type]` to `_backend_map.get` call. * **python/tvm_ffi/cpp/nvrtc.py** * Removed `type: ignore[import-not-found]` from `cuda.bindings` import. * **python/tvm_ffi/dataclasses/_utils.py** * Added `ty: ignore[unresolved-attribute]` to `func.__name__` and `func.__qualname__` assignments. * Removed `type: ignore` from `functools.wraps` call. * **python/tvm_ffi/dataclasses/field.py** * Updated `type: ignore[attr-defined]` to `ty: ignore[unresolved-import]` for `KW_ONLY` import. * Removed `type: ignore[assignment]` from `field` function parameters. * **python/tvm_ffi/error.py** * Added `ty: ignore[invalid-assignment]` to `node.col_offset` and `node.end_col_offset` assignments. * Changed `if callable(name_or_cls):` to `if isinstance(name_or_cls, type):`. * Added `ty: ignore[unresolved-attribute]` to `e.__tvm_ffi_error__` accesses. * **python/tvm_ffi/libinfo.py** * Updated `type: ignore[assignment]` to `ty: ignore[invalid-assignment]` for `im.distribution(package)`. * **python/tvm_ffi/module.py** * Updated `type: ignore[return-value]` to `ty: ignore[invalid-return-type]` for `imports_` return. * **python/tvm_ffi/registry.py** * Changed `if callable(func_name):` to `if not isinstance(func_name, str):`. * Added `ty: ignore[unresolved-attribute]` to `f.__name__` assignment. * **python/tvm_ffi/stub/cli.py** * Removed `type: ignore[union-attr]` from `defined_func_prefixes`. * Updated `type: ignore[assignment]` to `ty: ignore[invalid-assignment]` for `defined_objs`. * Removed `type: ignore[misc]` from `code.param` unpacking. * **python/tvm_ffi/stub/file_utils.py** * Removed `type: ignore[arg-type]` from `CodeBlock` initialization. * Updated `type: ignore[attr-defined]` to `ty: ignore[call-non-callable]` for `p.walk`. * **python/tvm_ffi/testing/testing.py** * Updated `type: ignore[attr-defined]` to `ty: ignore[unresolved-attribute]` for `__ffi_init__` call. * Updated `type: ignore[misc]` to `ty: ignore[dataclass-field-order]` for `v_bool` field. * **python/tvm_ffi/utils/_build_optional_torch_c_dlpack.py** * Removed `type: ignore[call-arg]` from `torch.utils.cpp_extension.include_paths`. * **tests/python/test_container.py** * Updated `type: ignore[arg-type]` to `ty: ignore[invalid-argument-type]` for `tvm_ffi.Array` and `tvm_ffi.Map` instantiations. * Updated `type: ignore[operator]` to `ty: ignore[unsupported-operator]` for array concatenation. * **tests/python/test_cubin_launcher.py** * Removed `ModuleType` import and explicit `torch: ModuleType | None` annotation. * Removed `type: ignore[import-not-found,no-redef]` from `torch` import. * **tests/python/test_dataclasses_c_class.py** * Updated `type: ignore[call-arg,misc]` to `ty: ignore[missing-argument]` for `_TestCxxClassDerivedDerived` instantiation. * Removed `type: ignore[call-arg]` from `_TestCxxInitSubset` instantiation. * Updated `type: ignore[misc]` to `ty: ignore[missing-argument, too-many-positional-arguments]` for `_TestCxxKwOnly`. * **tests/python/test_device.py** * Updated `type: ignore[arg-type]` to `ty: ignore[invalid-argument-type]` for `tvm_ffi.device` call. * **tests/python/test_dlpack_exchange_api.py** * Removed `type: ignore` comments from `torch` and `cpp_extension` imports and `torch = None` assignment. * Added `assert torch is not None` before using `torch.arange`. * Removed `type: ignore[attr-defined]` from `torch.Tensor.__dlpack_c_exchange_api__` access. * **tests/python/test_error.py** * Updated `type: ignore[attr-defined]` to `ty: ignore[unresolved-attribute]` for `__tvm_ffi_error__` accesses. * **tests/python/test_function.py** * Removed `type: ignore` from `__call__ = tvm_ffi.Function.__call__`. * **tests/python/test_load_inline.py** * Removed `ModuleType` import and explicit `torch: ModuleType | None` annotation. * Removed `type: ignore[no-redef]` from `torch` import. * Added `assert torch is not None` before using `torch` functions. * **tests/python/test_object.py** * Updated `type: ignore[call-arg]` to `ty: ignore[too-many-positional-arguments]` for `TestIntPair` instantiations. * Removed `type: ignore[attr-defined]` from method and attribute accesses. * Updated `type: ignore[assignment]` to `ty: ignore[invalid-assignment]` for attribute setters. * Updated `type: ignore[arg-type]` to `ty: ignore[invalid-argument-type]` for `tvm_ffi.testing.add_one` call. * Removed `type: ignore` comments from `_check_type` function. * **tests/python/test_optional_torch_c_dlpack.py** * Removed `type: ignore[assignment]` from `torch = None`. * Added `assert torch is not None` before using `Path(tvm_ffi.__file__)`. * **tests/python/test_stream.py** * Removed `ModuleType` import and explicit `torch: ModuleType | None` annotation. * Removed `type: ignore[no-redef]` from `torch` import. * Removed `type: ignore[import-not-found]` from `cuda.bindings` import. * **tests/python/test_tensor.py** * Removed `ModuleType` import and explicit `torch: ModuleType | None` annotation. * Removed `type: ignore[no-redef]` from `torch` import. * **tests/python/utils/test_embed_cubin.py** * Removed `ModuleType` import and explicit `torch: ModuleType | None` annotation. * Removed `type: ignore[import-not-found,no-redef]` from `torch` import. * **tests/python/utils/test_kwargs_wrapper.py** * Updated `type: ignore[list-item]` and `type: ignore[arg-type]` to `ty: ignore[invalid-argument-type]` for `make_kwargs_wrapper` calls. * Added `ty: ignore[unresolved-attribute]` to `wrapper_with_metadata.__name__` and `wrapper.__name__`. * **tests/scripts/benchmark_dlpack.py** * Removed `type: ignore[assignment]` from `tvm_ffi.core.DLTensorTestWrapper` assignments. * **tests/scripts/benchmark_kwargs_wrapper.py** * Removed `type: ignore[no-untyped-def]` from `target_func` definition. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
