gemini-code-assist[bot] commented on PR #434: URL: https://github.com/apache/tvm-ffi/pull/434#issuecomment-3864476380
## Summary of Changes Hello @Blealtan, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Rust ecosystem within TVM by introducing a dedicated stub generator. This new tool automates the creation of Rust FFI bindings, allowing developers to seamlessly integrate TVM's C++ functions and types into Rust projects. By generating a compilable Rust crate that wraps TVM-FFI DLLs, it streamlines the process of calling TVM functions from Rust, improving developer experience and reducing manual FFI boilerplate. ### Highlights * **New Rust Stub Generator**: Introduces `tvm-ffi-stubgen`, a new Rust crate and command-line tool designed to generate Rust stubs from `tvm-ffi` metadata. * **FFI Integration**: The generator supports creating compilable Rust crates that wrap TVM-FFI DLLs, mirroring the "STUB_INIT is on" mode of the existing Python stubgen. * **Core Logic**: Implements robust argument parsing using `clap`, FFI helpers for dynamic library loading and metadata querying, internal data models for Rust types, and schema parsing for type information. * **Code Generation**: Includes comprehensive logic for generating `Cargo.toml`, `lib.rs`, `functions.rs`, and `types.rs` files for the new stub crate. * **Workspace Integration**: The new `tvm-ffi-stubgen` crate has been added to the main Rust workspace. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **rust/Cargo.toml** * Added "tvm-ffi-stubgen" to the workspace members. * **rust/tvm-ffi-stubgen/Cargo.toml** * New file defining the `tvm-ffi-stubgen` package. * Specifies dependencies: `clap`, `libloading`, `serde`, `serde_json`, and `tvm-ffi`. * Configures the binary target `tvm-ffi-stubgen`. * **rust/tvm-ffi-stubgen/src/cli.rs** * New file implementing command-line argument parsing using `clap`. * Defines arguments for output directory, DLL paths, initialization prefixes, crate names, TVM-FFI path, and overwrite options. * **rust/tvm-ffi-stubgen/src/ffi.rs** * New file containing FFI utility functions. * Includes `Array` struct for handling TVM-FFI objects with reference counting. * Provides functions to load DLLs, list global function names, list registered type keys, query array size and items, get type info, and retrieve global function metadata. * **rust/tvm-ffi-stubgen/src/generate.rs** * New file containing the core code generation logic. * Functions for building type maps, function entries, type entries, and module structures. * Includes rendering logic for `Cargo.toml`, `lib.rs`, `functions.rs`, and `types.rs` for the generated stub crate. * Implements identifier sanitization and PascalCase conversion. * **rust/tvm-ffi-stubgen/src/lib.rs** * New file serving as the library entry point for the stub generator. * Orchestrates the overall stub generation process, including loading DLLs, filtering functions and types, building models, and writing generated files. * **rust/tvm-ffi-stubgen/src/main.rs** * New file, the main binary entry point for the `tvm-ffi-stubgen` command-line tool. * Parses arguments and calls the `run` function from `lib.rs`. * **rust/tvm-ffi-stubgen/src/model.rs** * New file defining data structures for representing Rust types (`RustType`, `RustTypeKind`), function signatures (`FunctionSig`), and generated code elements (`FunctionGen`, `MethodGen`, `TypeGen`, `ModuleNode`). * **rust/tvm-ffi-stubgen/src/schema.rs** * New file for parsing type schemas. * Defines `TypeSchema` and `TypeSchemaJson` for deserializing type metadata from JSON. * Provides functions to extract and parse type schemas. * **rust/tvm-ffi-stubgen/src/tests.rs** * New file containing integration tests for the `tvm-ffi-stubgen`. * Includes logic to resolve testing DLLs, create unique temporary directories, write integration test code, and run generated tests using `cargo test`. * **rust/tvm-ffi-stubgen/src/utils.rs** * New file with utility functions. * Includes functions for normalizing prefixes, ensuring output directory existence, locating the default `tvm-ffi` path, and calculating relative paths. </details> <details> <summary><b>Activity</b></summary> * The pull request was initially "vibed" (generated) using GPT-5.2-CodeX via Copilot. * The generated code was subsequently reviewed and refined by a human. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
