guan404ming commented on PR #18733: URL: https://github.com/apache/tvm/pull/18733#issuecomment-3867546088
> Thanks for the contribution. I think this is due to one of the legacy issues. Background: previously we used IntImm for constant attribute, and Integer redirects to IntImm. POD types like int cannot not appear in the nested contained. Since tvm-ffi refactor, now we have dedicated int, so ideally for constant attributes like strides, we should enforce them now to use POD int and such issue will disappear Thanks for the suggestion. I adjust the pr to migrate NN conv/pooling/grad attrs from Array<IntImm> to Array<int64_t> which I think to address the issue from real root cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
