gemini-code-assist[bot] commented on PR #438: URL: https://github.com/apache/tvm-ffi/pull/438#issuecomment-3869233311
## Summary of Changes Hello @junrushao, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the interoperability between C++ FFI objects and Python by introducing robust copying mechanisms. It allows users to perform shallow and deep copies, as well as field-based replacements, on C++-backed objects directly from Python, aligning their behavior with standard Python objects. This change improves the usability and flexibility of FFI objects within Python workflows. ### Highlights * **C++ Reflection API Enhancement**: Introduced `refl::enable_copy()` in the C++ reflection API to register a `__ffi_shallow_copy__` method, allowing C++ objects to define their shallow copy behavior using their copy constructor. * **Deep Copy Mechanism**: Developed `ObjectDeepCopier` in C++ (`src/ffi/extra/copy.cc`) which performs a two-phase deep copy: first, it walks the object graph using DFS to collect objects in topological order, then it creates shallow copies and replaces fields with previously copied values. * **Python Integration for Copy Operations**: Wired up Python's `__copy__`, `__deepcopy__`, and `__replace__` methods for FFI objects, ensuring proper copy semantics for both `@register_object` and `@c_class` types. Types without `enable_copy()` will now raise a `TypeError` when these methods are called. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **.pre-commit-config.yaml** * Updated the `ty check` pre-commit hook to include `--error-on-warning`, enforcing stricter type checking. * **CMakeLists.txt** * Added `src/ffi/extra/copy.cc` to the build system, incorporating the new C++ copy utilities. * **include/tvm/ffi/extra/copy.h** * Introduced the `DeepCopyValue` function declaration, providing a C++ API for deep copying `ffi::Any` values. * **include/tvm/ffi/reflection/registry.h** * Defined `refl::enable_copy` helper struct to facilitate registration of `__ffi_shallow_copy__` methods for C++ object types. * Extended `ObjectDef` to include a `def(enable_copy)` method, allowing types to easily opt-in to copy support. * **python/tvm_ffi/dataclasses/c_class.py** * Modified the `@c_class` decorator to call `_setup_copy_methods`, enabling Python copy methods for C++ classes. * **python/tvm_ffi/registry.py** * Implemented `_setup_copy_methods` to dynamically add `__copy__`, `__deepcopy__`, and `__replace__` to FFI object types based on the presence of `__ffi_shallow_copy__`. * Added helper functions (`_copy_supported`, `_deepcopy_supported`, `_replace_supported`, and their `_unsupported` counterparts) to handle the Python-side implementation and error reporting for copy operations. * Introduced `_get_deep_copy_func` and `_deep_copy_func_cache` for efficient lookup of the C++ deep copy function. * **src/ffi/extra/copy.cc** * Implemented the `ObjectDeepCopier` class, which performs a two-phase deep copy: graph traversal (DFS) to collect objects in topological order, followed by shallow copying and field replacement. * Provided the `DeepCopyValue` function, exposed as `ffi.DeepCopy` to the FFI, which leverages `ObjectDeepCopier`. * **src/ffi/testing/testing.cc** * Updated test object definitions (`TestIntPairObj`, `TestObjectBase`, `TestObjectDerived`, `SchemaAllTypesObj`) to use `refl::enable_copy()`, making them copyable for testing purposes. * **tests/python/test_copy.py** * Added a new test file with 17 tests covering various aspects of `copy.copy()`, `copy.deepcopy()`, and `__replace__` for FFI objects, including basic fields, new object identity, mutable fields, mutation isolation, derived type preservation, nested objects, shared references, and error handling for unsupported types. </details> <details> <summary><b>Activity</b></summary> * A new C++ implementation for deep copying FFI objects has been introduced. * Python's `copy` module functionality (`__copy__`, `__deepcopy__`, `__replace__`) has been integrated with FFI objects. * Comprehensive test cases have been added to validate the new copy mechanisms across various scenarios. * The build system and pre-commit hooks were updated to support the new C++ files and enforce stricter code quality. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
