gemini-code-assist[bot] commented on code in PR #441:
URL: https://github.com/apache/tvm-ffi/pull/441#discussion_r2795018925


##########
.pre-commit-config.yaml:
##########
@@ -117,7 +117,7 @@ repos:
     hooks:
       - id: ty
         name: ty check
-        entry: uvx ty check
+        entry: uv run --isolated --python 3.14 --with ty==0.0.15 --group dev 
ty check --error-on-warning

Review Comment:
   ![critical](https://www.gstatic.com/codereviewagent/critical.svg)
   
   The `uv run` command does not appear to support the `--group` flag. This 
will likely cause the pre-commit hook to fail. The `--group` flag is available 
for `uv pip install`, but not for `uv run`.
   
   To run `ty` in an isolated environment, specifying it with `--with` is 
sufficient. If other packages from the `dev` group are necessary for `ty` to 
execute, they should be added with separate `--with` flags.
   
   ```yaml
           entry: uv run --isolated --python 3.14 --with ty==0.0.15 ty check 
--error-on-warning
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to