gemini-code-assist[bot] commented on PR #18759: URL: https://github.com/apache/tvm/pull/18759#issuecomment-3887431976
## Summary of Changes Hello @MasterJH5574, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the codebase by eliminating the external `picojson` dependency. It replaces all instances of `picojson` usage with the internal `tvm::ffi::json` API, streamlining the project's dependencies and promoting a more unified approach to JSON handling within the system. This change simplifies the build process and reduces the overall footprint of third-party libraries. ### Highlights * **Picojson Dependency Removal**: The external `picojson` library and all its related files (headers, README, test, license) have been completely removed from the codebase. * **Migration to Internal JSON API**: All previous usages of `picojson` for JSON parsing and manipulation have been migrated to the new `tvm::ffi::json` API, which is built on the FFI type system. * **Build System and License Updates**: The build configuration (CMakeLists.txt, LibInfo.cmake, web/Makefile) and the project's LICENSE file have been updated to reflect the removal of `picojson`. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **3rdparty/picojson/README.md** * Removed file. * **3rdparty/picojson/picojson.h** * Removed file. * **3rdparty/picojson/test_picojson.cpp** * Removed file. * **CMakeLists.txt** * Removed `PICOJSON_PATH` option. * Removed `picojson` from system include directories. * **LICENSE** * Removed entry for `3rdparty/picojson`. * **cmake/modules/LibInfo.cmake** * Removed `TVM_INFO_PICOJSON_PATH` variable. * **licenses/LICENSE.picojson.txt** * Removed file. * **src/runtime/contrib/nvshmem/init.cc** * Updated include from `picojson.h` to `tvm/ffi/extra/json.h`. * Refactored JSON parsing logic to use `tvm::ffi::json` API. * **src/runtime/disco/loader.cc** * Removed `PICOJSON_USE_INT64` and `__STDC_FORMAT_MACROS` preprocessor definitions. * Updated include from `picojson.h` to `tvm/ffi/extra/json.h`. * Refactored JSON parsing logic to use `tvm::ffi::json` API, including `json::Parse`, `json::Object`, `json::Array`, and `ffi::Any` casts. * **src/runtime/vm/tensor_cache_support.cc** * Removed `PICOJSON_USE_INT64` and `__STDC_FORMAT_MACROS` preprocessor definitions. * Updated include from `picojson.h` to `tvm/ffi/extra/json.h`. * Refactored JSON parsing logic to use `tvm::ffi::json` API, including `json::Parse`, `json::Object`, `json::Array`, and `ffi::Any` casts. * **src/support/libinfo.cc** * Removed `PICOJSON_PATH` from the `GetLibInfo` map. * **web/Makefile** * Removed `3rdparty/picojson` from `INCLUDE_FLAGS`. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
