gemini-code-assist[bot] commented on code in PR #18760: URL: https://github.com/apache/tvm/pull/18760#discussion_r2796182113
########## LICENSE: ########## @@ -233,20 +231,15 @@ BSD 2-clause License + zlib License MIT License ----------- -3rdparty/libcrc -3rdparty/cma 3rdparty/compiler-rt/builtin_fp16.h -3rdparty/cnpy The Unlicense ------------- 3rdparty/rang -3rdparty/zlib BSD 3-Clause "New" or "Revised" License --------------------------------------- 3rdparty/cutlass -3rdparty/libbacktrace Review Comment:  Removing `libbacktrace` from the license attributions is incorrect. The `USE_LIBBACKTRACE` option in `CMakeLists.txt` indicates that it is still an optional dependency. To maintain correct license attribution, the entry for `libbacktrace` should be restored. ########## LICENSE: ########## @@ -209,10 +209,8 @@ for text of these licenses. Apache Software Foundation License 2.0 -------------------------------------- -3rdparty/dlpack Review Comment:  Removing `dlpack` from the license attributions is likely a mistake. `dlpack` is a core data structure for tensor interoperability in the ecosystem and is likely still a dependency, even if indirectly. Please restore the `dlpack` entry to ensure correct license compliance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
