gemini-code-assist[bot] commented on PR #18773: URL: https://github.com/apache/tvm/pull/18773#issuecomment-3896008829
## Summary of Changes Hello @Mr-Neutr0n, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the ONNX frontend where the `Gelu` operator's `approximate` attribute, introduced in Opset 20, was not being respected. By implementing version-specific handling, TVM can now correctly interpret and apply the `tanh` approximation for Gelu when specified, preventing silent miscomputations and ensuring accurate model conversion from ONNX to Relax. ### Highlights * **ONNX Gelu Approximation Handling**: The ONNX frontend for the `Gelu` operator now correctly handles the `approximate` attribute introduced in ONNX Opset 20, resolving an issue where `approximate="tanh"` was ignored. * **New `_impl_v20` for Gelu Converter**: A new `_impl_v20` method has been added to the `Gelu` converter class. This method checks the `approximate` attribute and routes to `relax.op.nn.gelu_tanh` when `approximate="tanh"` and `relax.op.nn.gelu` otherwise. * **Backward Compatibility Maintained**: The existing `_impl_v1` method for the `Gelu` converter remains unchanged, ensuring backward compatibility for models using the Microsoft onnxruntime contrib opset. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **python/tvm/relax/frontend/onnx/onnx_frontend.py** * Added `_impl_v20` method to the `Gelu` converter to handle the `approximate` attribute from ONNX Opset 20. * Updated the `Gelu` class docstring to reflect support for both Microsoft onnxruntime contrib opset and ONNX Opset 20+. </details> <details> <summary><b>Activity</b></summary> * No specific activity has been recorded for this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
