gemini-code-assist[bot] commented on PR #18774: URL: https://github.com/apache/tvm/pull/18774#issuecomment-3896065798
## Summary of Changes Hello @Mr-Neutr0n, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the ONNX frontend's `Split` operator within TVM Relax, which previously failed when encountering uneven tensor dimensions combined with the `num_outputs` attribute. The core of the solution involves dynamically computing precise split indices based on the ONNX Opset 18 specification, allowing for correct handling of non-divisible tensor splits. This enhancement significantly improves the robustness and compliance of the ONNX frontend, preventing crashes and ensuring accurate tensor partitioning in more complex scenarios. ### Highlights * **ONNX Split Operator Fix**: Resolved an issue where the ONNX frontend's `Split` operator crashed when attempting to split a tensor into an uneven number of parts using `num_outputs`, which previously only supported perfectly divisible cases. * **Uneven Split Handling**: Implemented a new helper method, `_compute_split_indices`, to calculate explicit cumulative split indices for static input shapes, adhering to the ONNX Opset 18 specification for ceil-based block sizes (e.g., splitting a length-10 tensor into 3 parts yields `[4, 4, 2]`). * **Test Coverage**: Added new test cases to validate the correct behavior of the `Split` operator for both 1D and 2D uneven splits, ensuring compliance with the ONNX Opset 18 specification. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **python/tvm/relax/frontend/onnx/onnx_frontend.py** * Added `_compute_split_indices` method to correctly calculate split indices for uneven splits based on ONNX Opset 18. * Updated `_impl_v1` and `_impl_v13` to utilize the new `_compute_split_indices` method when `split` attribute is not provided. * **tests/python/relax/test_frontend_onnx.py** * Added new test cases for 1D and 2D uneven splits to verify the fix. </details> <details> <summary><b>Activity</b></summary> * No activity found for this pull request. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
