gemini-code-assist[bot] commented on PR #451: URL: https://github.com/apache/tvm-ffi/pull/451#issuecomment-3905241890
## Summary of Changes Hello @tqchen, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of the `Any` type by allowing users to register custom hashing and equality comparison logic for specific object types. This is achieved through a new type attribute column mechanism, which enables more precise control over how custom objects are handled in data structures that rely on these operations. The change also includes a minor refactoring of error handling utilities for better organization. ### Highlights * **Customizable AnyHash and AnyEqual**: Introduced the ability to define custom hash and equality comparison functions for `Any` objects via type attribute columns (`__any_hash__` and `__any_equal__`). This allows for specialized handling of object types beyond the default `Any` hashing and equality logic. * **Error Handling Refactoring**: Moved `MoveFromSafeCallRaised` and `SetSafeCallRaised` error handling utilities from `function_details.h` to `error.h` to centralize error management within the FFI system. * **New Test Cases**: Added comprehensive C++ test cases to validate the functionality of custom `AnyHash` and `AnyEqual` implementations, covering both opaque pointer and `ffi.Function` registration paths. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **include/tvm/ffi/any.h** * Modified `AnyHash` and `AnyEqual` structs to include `public:` access specifiers. * Implemented logic within `AnyHash::operator()` to check for and invoke custom hash functions registered via the `__any_hash__` type attribute column. * Added private helper functions `GetAnyHashTypeAttrColumn` and `CallCustomAnyHash` to `AnyHash` to manage custom hash function retrieval and execution. * Implemented logic within `AnyEqual::operator()` to check for and invoke custom equality functions registered via the `__any_equal__` type attribute column. * Added private helper functions `GetAnyEqualTypeAttrColumn` and `CallCustomAnyEqual` to `AnyEqual` to manage custom equality function retrieval and execution. * **include/tvm/ffi/error.h** * Added `MoveFromSafeCallRaised` and `SetSafeCallRaised` functions to centralize error handling for safe calls. * **include/tvm/ffi/function_details.h** * Removed `MoveFromSafeCallRaised` and `SetSafeCallRaised` functions, as they were relocated to `error.h`. * **src/ffi/container.cc** * Ensured the initialization of type attribute columns for `__any_hash__` and `__any_equal__`. * **tests/cpp/test_any.cc** * Added `CustomAnyHash` test case to verify custom hashing for `Any` objects, including `OpaquePtr` and `ffi.Function` paths. * Added `CustomAnyEqual` test case to verify custom equality for `Any` objects, including `OpaquePtr` and `ffi.Function` paths. * **tests/cpp/testing_object.h** * Included `tvm/ffi/any.h` header. * Added `CustomAnyHash` and `CustomAnyEqual` static methods to the `TInt` class. * Registered `TInt::CustomAnyHash` and `TInt::CustomAnyEqual` as `__any_hash__` and `__any_equal__` type attributes for `TIntObj`. * Moved `TFloatObj::RegisterReflection` definition outside the class. * Added `CustomAnyHash` and `CustomAnyEqual` static methods to the `TFloat` class. * Registered `TFloat::CustomAnyHash` and `TFloat::CustomAnyEqual` as `__any_hash__` and `__any_equal__` type attributes for `TFloatObj`. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
