tqchen commented on issue #457: URL: https://github.com/apache/tvm-ffi/issues/457#issuecomment-3908161338
generally if exception happens in dtor something really bad happens. so that is why mostly dtor is noexcept. Constructor safety is generally more important. In this particular case, we should coument deleter being non-throwing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
