gemini-code-assist[bot] commented on PR #18818: URL: https://github.com/apache/tvm/pull/18818#issuecomment-3958664359
## Summary of Changes Hello @mshr-h, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical build failures encountered when compiling TVM with LLVM version 22 or newer. The changes primarily involve updating the TVM codebase to align with recent API modifications in LLVM's target and command-line option handling, ensuring continued compatibility and successful compilation across different LLVM versions. ### Highlights * **LLVM Command-Line Option Handling**: Adapted LLVM command-line option parsing to use `options.find()` for LLVM 22 and newer versions, replacing `options.count()` for checking option existence. * **Floating-Point Option Compatibility**: Conditionally compiled out the `target_options_.UnsafeFPMath` setting for LLVM 22+, as this option is no longer available in newer LLVM versions. * **Target Triple Handling**: Updated target instance and machine creation functions (`CreateLLVMTargetInstance`, `CreateLLVMTargetMachine`) to pass an `llvm::Triple` object instead of a raw string for the target triple when building with LLVM 22+. * **Robust Option Retrieval**: Refactored LLVM option retrieval logic in `GetOptionValue` and `ApplyLLVMOptions` to ensure safe access using `options.find()` and added null checks for compatibility with LLVM 22 API changes. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **src/target/llvm/llvm_instance.cc** * Modified the logic for retrieving registered LLVM command-line options to use `options.find()` for LLVM 22+ compatibility. * Wrapped the `target_options_.UnsafeFPMath = false;` assignment in a conditional block to exclude it for LLVM 22+. * Updated `CreateLLVMTargetInstance` to construct an `llvm::Triple` object before calling `llvm::TargetRegistry::lookupTarget` for LLVM 22+. * Updated `CreateLLVMTargetMachine` to construct an `llvm::Triple` object before calling `llvm_instance->createTargetMachine` for LLVM 22+. * Revised `GetOptionValue` to safely retrieve `llvm::cl::Option*` using `options.find()` for LLVM 22+ and added a null check. * Adjusted `ApplyLLVMOptions` to retrieve `llvm::cl::Option*` using `options.find()` for LLVM 22+ and added a null check. </details> <details> <summary><b>Activity</b></summary> * No human activity has been recorded on this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
