tqchen commented on code in PR #18819:
URL: https://github.com/apache/tvm/pull/18819#discussion_r2853424603
##########
src/runtime/metal/metal_module.mm:
##########
@@ -212,7 +212,7 @@ void operator()(ffi::PackedArgs args, ffi::Any* rv, const
ArgUnion64* pack_args)
ThreadWorkLoad wl = launch_param_config_.Extract(args);
int blockSize = wl.block_dim(0) * wl.block_dim(1) * wl.block_dim(2);
auto maxTotalThreadsPerThreadgroup =
scache_[device_id].maxTotalThreadsPerThreadgroup;
- CHECK_LE(blockSize, maxTotalThreadsPerThreadgroup);
+ TVM_FFI_CHECK_LE(blockSize, maxTotalThreadsPerThreadgroup);
Review Comment:
TVM_FFI_CHECK_LE needs to have explicitly error type as third argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
