MasterJH5574 commented on code in PR #18823:
URL: https://github.com/apache/tvm/pull/18823#discussion_r2855228758
##########
src/s_tir/transform/lower_thread_allreduce.cc:
##########
@@ -510,7 +510,9 @@ class ThreadAllreduceBuilder final : public StmtExprMutator
{
//
// The former may cause dead lock as there is a divergent
// branch with a warp sync call inside.
- PrimExpr other = WarpShuffle(builtin::tvm_warp_shuffle_down(),
mask_buffer, val, offset);
+ bool cast_offset_to_uint = target_->kind->name == "webgpu";
Review Comment:
For changes in `src/s_tir/transform/lower_thread_allreduce.cc`, could you
please add a unit test in
`tests/python/tir-transform/test_tir_transform_lower_thread_all_reduce.py` to
test the expected behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
