The GitHub Actions job "Lint" on tvm.git/reland-resize-fix has failed.
Run started by GitHub user tqchen (triggered by tqchen).

Head commit for run:
9a793e7ceecbb31806bc607fc86b25418f482037 / tqchen <[email protected]>
[BugFix][TOPI] Fix resize accuracy issue with non-floor rounding

`can_convert_multiply_to_intdiv` was enabled unconditionally for
`nearest_neighbor` + `asymmetric` mode, even when `rounding_method` is
not `floor`.  This converted the mapped coordinate via integer division
(equivalent to floor) regardless of the requested rounding, producing
wrong results whenever the target size is an exact integer multiple of
the source size.

Fix: guard the `can_convert_multiply_to_intdiv` optimisation so it only
activates when `rounding_method` is `"floor"` or `""` (which defaults to
`"floor"` for asymmetric mode).

Also update the Python reference implementation (`resize_python.py`) to
accept and thread a `rounding_method` parameter through all public entry
points (`get_index`, `resize3d_nearest`, `resize3d_ncdhw`, `resize1d_python`,
`resize2d_python`, `resize3d_python`), so the reference matches the
corrected TVM behaviour.

Add `tests/python/te/test_topi_resize2d.py` with regression tests that
exercise the buggy path (non-floor rounding + asymmetric + integer
scale factor) as well as sanity checks for floor rounding and
non-integer scale factors.

Fixes: https://github.com/apache/tvm/pull/16137

Report URL: https://github.com/apache/tvm/actions/runs/22454623271

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to