gemini-code-assist[bot] commented on PR #18845: URL: https://github.com/apache/tvm/pull/18845#issuecomment-3977126507
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring effort to streamline the TVM project by completely excising the Multi-System Compiler (MSC) contrib module. This removal addresses a self-contained and unused component, leading to a substantial reduction in code volume and simplifying the overall project structure. The changes primarily involve deleting all associated source files, build configurations, and Python package references, ensuring a clean and isolated removal. ### Highlights * **Module Removal**: The entire Multi-System Compiler (MSC) contrib module has been removed from the TVM codebase. * **Code Clean-up**: Approximately 246 files and 57,500 lines of code related to MSC have been deleted, significantly reducing the codebase size. * **Build System Updates**: References to MSC have been removed from CMake configuration files (`CMakeLists.txt`, `cmake/config.cmake`, `cmake/modules/LibInfo.cmake`) and Python project settings (`pyproject.toml`). * **Independent Removal**: The MSC module was self-contained with no cross-references from core TVM, allowing for its complete removal without impacting other modules like MSCCLPP. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **CMakeLists.txt** * Removed the `USE_MSC` option definition. * Removed the inclusion of the `cmake/modules/contrib/MSC.cmake` file. * **cmake/config.cmake** * Eliminated the `USE_MSC` configuration variable and its descriptive comment. * **cmake/modules/LibInfo.cmake** * Removed the `TVM_INFO_USE_MSC` definition from the library information function. * **cmake/modules/contrib/MSC.cmake** * Deleted the CMake module responsible for configuring MSC support. * **pyproject.toml** * Removed per-file ignore rules for the `python/tvm/contrib/msc/**` directory. * **python/tvm/contrib/msc/__init__.py** * Deleted the `__init__.py` file for the top-level MSC Python module. * **python/tvm/contrib/msc/core/__init__.py** * Deleted the `__init__.py` file for the MSC core Python module. * **python/tvm/contrib/msc/core/_ffi_api.py** * Deleted the FFI API binding file for MSC core. * **python/tvm/contrib/msc/core/codegen/__init__.py** * Deleted the `__init__.py` file for the MSC core codegen module. * **python/tvm/contrib/msc/core/codegen/codegen.py** * Deleted the core code generation logic for MSC. * **python/tvm/contrib/msc/core/codegen/sources.py** * Deleted the source code generation utilities for MSC. * **python/tvm/contrib/msc/core/frontend/__init__.py** * Deleted the `__init__.py` file for the MSC core frontend module. * **python/tvm/contrib/msc/core/frontend/translate.py** * Deleted the translation logic from Relax to MSCGraph. * **python/tvm/contrib/msc/core/gym/__init__.py** * Deleted the `__init__.py` file for the MSC core gym module. * **python/tvm/contrib/msc/core/gym/agent/__init__.py** * Deleted the `__init__.py` file for the MSC core gym agent module. * **python/tvm/contrib/msc/core/gym/agent/base_agent.py** * Deleted the base agent implementation for MSC gym. * **python/tvm/contrib/msc/core/gym/agent/method.py** * Deleted the agent method definitions for MSC gym. * **python/tvm/contrib/msc/core/gym/agent/search_agent.py** * Deleted the search agent implementations for MSC gym. * **python/tvm/contrib/msc/core/gym/control/__init__.py** * Deleted the `__init__.py` file for the MSC core gym control module. * **python/tvm/contrib/msc/core/gym/control/configer.py** * Deleted the configer for MSC gym control. * **python/tvm/contrib/msc/core/gym/control/controller.py** * Deleted the controller for MSC gym. * **python/tvm/contrib/msc/core/gym/control/namespace.py** * Deleted the namespace definitions for MSC gym control. * **python/tvm/contrib/msc/core/gym/control/service.py** * Deleted the service implementations for MSC gym control. * **python/tvm/contrib/msc/core/gym/control/worker.py** * Deleted the worker implementations for MSC gym control. * **python/tvm/contrib/msc/core/gym/environment/__init__.py** * Deleted the `__init__.py` file for the MSC core gym environment module. * **python/tvm/contrib/msc/core/gym/environment/base_env.py** * Deleted the base environment implementation for MSC gym. * **python/tvm/contrib/msc/core/gym/environment/method.py** * Deleted the environment method definitions for MSC gym. * **python/tvm/contrib/msc/core/gym/environment/prune_env.py** * Deleted the pruning environment for MSC gym. * **python/tvm/contrib/msc/core/gym/environment/quantize_env.py** * Deleted the quantization environment for MSC gym. * **python/tvm/contrib/msc/core/gym/namespace.py** * Deleted the namespace definitions for MSC gym. * **python/tvm/contrib/msc/core/ir/__init__.py** * Deleted the `__init__.py` file for the MSC core IR module. * **python/tvm/contrib/msc/core/ir/graph.py** * Deleted the graph representation and manipulation logic for MSC. * **python/tvm/contrib/msc/core/runtime/__init__.py** * Deleted the `__init__.py` file for the MSC core runtime module. * **python/tvm/contrib/msc/core/runtime/hook.py** * Deleted the runtime hook definitions for MSC. * **python/tvm/contrib/msc/core/runtime/jit.py** * Deleted the Just-In-Time compilation logic for MSC. * **python/tvm/contrib/msc/core/runtime/runner.py** * Deleted the core runner implementations for MSC. * **python/tvm/contrib/msc/core/tools/__init__.py** * Deleted the `__init__.py` file for the MSC core tools module. * **python/tvm/contrib/msc/core/tools/configer.py** * Deleted the tool configuration utilities for MSC. * **python/tvm/contrib/msc/core/tools/distill/__init__.py** * Deleted the `__init__.py` file for the MSC core distillation tool. * **python/tvm/contrib/msc/core/tools/distill/configer.py** * Deleted the configuration for MSC distillation tool. * **python/tvm/contrib/msc/core/tools/distill/distiller.py** * Deleted the distillation tool implementation for MSC. * **python/tvm/contrib/msc/core/tools/distill/method.py** * Deleted the distillation method definitions for MSC. * **python/tvm/contrib/msc/core/tools/execute.py** * Deleted the tool execution utilities for MSC. * **python/tvm/contrib/msc/core/tools/prune/__init__.py** * Deleted the `__init__.py` file for the MSC core pruning tool. * **python/tvm/contrib/msc/core/tools/prune/configer.py** * Deleted the configuration for MSC pruning tool. * **python/tvm/contrib/msc/core/tools/prune/method.py** * Deleted the pruning method definitions for MSC. * **python/tvm/contrib/msc/core/tools/prune/pruner.py** * Deleted the pruning tool implementation for MSC. * **python/tvm/contrib/msc/core/tools/quantize/__init__.py** * Deleted the `__init__.py` file for the MSC core quantization tool. * **python/tvm/contrib/msc/core/tools/quantize/configer.py** * Deleted the configuration for MSC quantization tool. * **python/tvm/contrib/msc/core/tools/quantize/method.py** * Deleted the quantization method definitions for MSC. * **python/tvm/contrib/msc/core/tools/quantize/quantizer.py** * Deleted the quantization tool implementation for MSC. * **python/tvm/contrib/msc/core/tools/tool.py** * Deleted the base tool definitions and utilities for MSC. * **python/tvm/contrib/msc/core/tools/track/__init__.py** * Deleted the `__init__.py` file for the MSC core tracking tool. * **python/tvm/contrib/msc/core/tools/track/configer.py** * Deleted the configuration for MSC tracking tool. * **python/tvm/contrib/msc/core/tools/track/method.py** * Deleted the tracking method definitions for MSC. * **python/tvm/contrib/msc/core/tools/track/tracker.py** * Deleted the tracking tool implementation for MSC. * **python/tvm/contrib/msc/core/transform/__init__.py** * Deleted the `__init__.py` file for the MSC core transform module. * **python/tvm/contrib/msc/core/transform/pattern.py** * Deleted the pattern matching definitions for MSC transforms. * **python/tvm/contrib/msc/core/transform/transform.py** * Deleted the core transform passes for MSC. * **python/tvm/contrib/msc/core/utils/__init__.py** * Deleted the `__init__.py` file for the MSC core utilities module. * **python/tvm/contrib/msc/core/utils/arguments.py** * Deleted the argument parsing and dictionary manipulation utilities for MSC. * **python/tvm/contrib/msc/core/utils/dataset.py** * Deleted the dataset loading and saving utilities for MSC. * **python/tvm/contrib/msc/core/utils/expr.py** * Deleted the expression utility functions for MSC. * **python/tvm/contrib/msc/core/utils/file.py** * Deleted the file and directory management utilities for MSC. * **python/tvm/contrib/msc/core/utils/info.py** * Deleted the array inspection and comparison utilities for MSC. * **python/tvm/contrib/msc/core/utils/log.py** * Deleted the logging utilities for MSC. * **python/tvm/contrib/msc/core/utils/message.py** * Deleted the message and timing utilities for MSC. * **python/tvm/contrib/msc/core/utils/namespace.py** * Deleted the namespace and key definitions for MSC. * **python/tvm/contrib/msc/core/utils/register.py** * Deleted the registration mechanisms for MSC components. * **python/tvm/contrib/msc/framework/__init__.py** * Deleted the `__init__.py` file for the MSC framework module. * **python/tvm/contrib/msc/framework/tensorflow/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow framework. * **python/tvm/contrib/msc/framework/tensorflow/_ffi_api.py** * Deleted the FFI API binding file for MSC Tensorflow. * **python/tvm/contrib/msc/framework/tensorflow/codegen/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow codegen module. * **python/tvm/contrib/msc/framework/tensorflow/codegen/codegen.py** * Deleted the code generation logic for MSC Tensorflow. * **python/tvm/contrib/msc/framework/tensorflow/frontend/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow frontend module. * **python/tvm/contrib/msc/framework/tensorflow/frontend/translate.py** * Deleted the translation logic from Tensorflow to MSCGraph. * **python/tvm/contrib/msc/framework/tensorflow/runtime/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow runtime module. * **python/tvm/contrib/msc/framework/tensorflow/runtime/runner.py** * Deleted the runner implementation for MSC Tensorflow. * **python/tvm/contrib/msc/framework/tensorflow/tools/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow tools module. * **python/tvm/contrib/msc/framework/tensorflow/tools/distill/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow distillation tool. * **python/tvm/contrib/msc/framework/tensorflow/tools/distill/distiller.py** * Deleted the distillation tool implementation for MSC Tensorflow. * **python/tvm/contrib/msc/framework/tensorflow/tools/prune/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow pruning tool. * **python/tvm/contrib/msc/framework/tensorflow/tools/prune/pruner.py** * Deleted the pruning tool implementation for MSC Tensorflow. * **python/tvm/contrib/msc/framework/tensorflow/tools/quantize/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow quantization tool. * **python/tvm/contrib/msc/framework/tensorflow/tools/quantize/quantizer.py** * Deleted the quantization tool implementation for MSC Tensorflow. * **python/tvm/contrib/msc/framework/tensorflow/tools/track/__init__.py** * Deleted the `__init__.py` file for the MSC Tensorflow tracking tool. * **python/tvm/contrib/msc/framework/tensorflow/tools/track/tracker.py** * Deleted the tracking tool implementation for MSC Tensorflow. * **python/tvm/contrib/msc/framework/tensorrt/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT framework. * **python/tvm/contrib/msc/framework/tensorrt/_ffi_api.py** * Deleted the FFI API binding file for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/codegen/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT codegen module. * **python/tvm/contrib/msc/framework/tensorrt/codegen/codegen.py** * Deleted the code generation logic for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/codegen/sources.py** * Deleted the source code generation utilities for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/codegen/utils.py** * Deleted the code generation utilities for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/frontend/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT frontend module. * **python/tvm/contrib/msc/framework/tensorrt/frontend/translate.py** * Deleted the translation logic for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/runtime/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT runtime module. * **python/tvm/contrib/msc/framework/tensorrt/runtime/runner.py** * Deleted the runner implementation for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/tools/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT tools module. * **python/tvm/contrib/msc/framework/tensorrt/tools/distill/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT distillation tool. * **python/tvm/contrib/msc/framework/tensorrt/tools/distill/distiller.py** * Deleted the distillation tool implementation for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/tools/prune/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT pruning tool. * **python/tvm/contrib/msc/framework/tensorrt/tools/prune/pruner.py** * Deleted the pruning tool implementation for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/tools/quantize/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT quantization tool. * **python/tvm/contrib/msc/framework/tensorrt/tools/quantize/method.py** * Deleted the quantization method definitions for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/tools/quantize/quantizer.py** * Deleted the quantization tool implementation for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/tools/track/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT tracking tool. * **python/tvm/contrib/msc/framework/tensorrt/tools/track/tracker.py** * Deleted the tracking tool implementation for MSC TensorRT. * **python/tvm/contrib/msc/framework/tensorrt/transform/__init__.py** * Deleted the `__init__.py` file for the MSC TensorRT transform module. * **python/tvm/contrib/msc/framework/tensorrt/transform/pattern.py** * Deleted the pattern matching definitions for MSC TensorRT transforms. * **python/tvm/contrib/msc/framework/tensorrt/transform/transform.py** * Deleted the core transform passes for MSC TensorRT. * **python/tvm/contrib/msc/framework/torch/__init__.py** * Deleted the `__init__.py` file for the MSC PyTorch framework. * **python/tvm/contrib/msc/framework/torch/_ffi_api.py** * Deleted the FFI API binding file for MSC PyTorch. * **python/tvm/contrib/msc/framework/torch/codegen/__init__.py** * Deleted the `__init__.py` file for the MSC PyTorch codegen module. * **python/tvm/contrib/msc/framework/torch/codegen/codegen.py** * Deleted the code generation logic for MSC PyTorch. * **python/tvm/contrib/msc/framework/torch/frontend/__init__.py** * Deleted the `__init__.py` file for the MSC PyTorch frontend module. * **python/tvm/contrib/msc/framework/torch/frontend/translate.py** * Deleted the translation logic from PyTorch to MSCGraph. * **python/tvm/contrib/msc/framework/torch/runtime/__init__.py** * Deleted the `__init__.py` file for the MSC PyTorch runtime module. * **python/tvm/contrib/msc/framework/torch/runtime/jit.py** * Deleted the Just-In-Time compilation logic for MSC PyTorch. * **python/tvm/contrib/msc/framework/torch/runtime/runner.py** * Deleted the runner implementation for MSC PyTorch. * **python/tvm/contrib/msc/framework/torch/tools/__init__.py** * Deleted the `__init__.py` file for the MSC PyTorch tools module. * **python/tvm/contrib/msc/framework/torch/tools/distill/__init__.py** * Deleted the `__init__.py` file for the MSC PyTorch distillation tool. * **python/tvm/contrib/msc/framework/torch/tools/distill/distiller.py** * Deleted the distillation tool implementation for MSC PyTorch. </details> <details> <summary><b>Activity</b></summary> * The author confirmed that no `contrib/msc` or `USE_MSC` references remain after grepping the codebase. * The author verified that `pre-commit run --all-files` passes, indicating adherence to code style and quality standards. * The author plans to confirm CI build success, ensuring the changes do not introduce regressions. * The author plans to verify that `import tvm; import tvm.contrib` still works as expected after the module removal. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
