gemini-code-assist[bot] commented on PR #18852: URL: https://github.com/apache/tvm/pull/18852#issuecomment-3977195275
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refactoring the project by completely removing the `mscclpp` contribution module. This module, initially added as an experimental integration, was determined to be unused within the codebase. Its removal simplifies the project structure by eliminating associated header files, CMake build configurations, and runtime source code, contributing to a cleaner and more maintainable system. ### Highlights * **Module Removal**: Removed the `mscclpp` (Microsoft MSCCL++) contrib module, which was an experimental integration and found to be unused. * **Codebase Cleanup**: Eliminated all associated 3rdparty headers, CMake modules, runtime source files, and build configuration options related to `mscclpp`. * **Project Simplification**: Streamlined the codebase by removing unnecessary components, reducing complexity and potential maintenance overhead. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **3rdparty/mscclpp/include/common.h** * Removed the `mscclpp` common header file. * **3rdparty/mscclpp/include/msccl.cuh** * Removed the `mscclpp` CUDA header file. * **3rdparty/mscclpp/include/msccl.h** * Removed the main `mscclpp` public API header file. * **CMakeLists.txt** * Removed the `USE_MSCCL` build option. * Removed the `MSCCLPP.cmake` module inclusion. * **cmake/config.cmake** * Removed the `USE_MSCCL` configuration variable. * **cmake/modules/LibInfo.cmake** * Removed the `TVM_INFO_USE_MSCCL` variable from library information generation. * **cmake/modules/contrib/MSCCLPP.cmake** * Removed the `MSCCLPP` CMake module. * **src/runtime/contrib/mscclpp/allreduce.cu** * Removed the `mscclpp` allreduce CUDA implementation file. * **src/support/libinfo.cc** * Removed the `TVM_INFO_USE_MSCCLPP` preprocessor definition. * Removed the `USE_MSCCL` entry from the `GetLibInfo` map. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
