gemini-code-assist[bot] commented on code in PR #18851: URL: https://github.com/apache/tvm/pull/18851#discussion_r2867490932
########## tests/python/contrib/test_hexagon/README.md: ########## @@ -83,23 +79,19 @@ To use hexagon docker image, install TVM and Hexagon API follow these steps from # Build TVM rm -rf build -./tests/scripts/task_config_build_hexagon.sh build -cd build -cmake .. +mkdir build && cd build +cmake -DUSE_LLVM=ON \ + -DUSE_RPC=ON \ + -DUSE_HEXAGON_SDK=$HEXAGON_SDK_PATH \ + -DUSE_HEXAGON=ON .. make -j2 Review Comment:  The instructions for building with the Docker image are now incomplete. The "Build Hexagon API" step, which was previously handled by the now-removed `task_build_hexagon_api.sh` script, is missing. This step is essential for running Hexagon tests. Please inline the commands from the old script to provide complete instructions. ```markdown mkdir build && cd build cmake -DUSE_LLVM=ON \ -DUSE_RPC=ON \ -DUSE_HEXAGON_SDK=$HEXAGON_SDK_PATH \ -DUSE_HEXAGON=ON .. make -j2 cd .. # Build Hexagon API ( cd apps/hexagon_api rm -rf build mkdir -p build cd build rm -rf ../../build/hexagon_api_output cmake -DUSE_HEXAGON_ARCH=v68 \ -DUSE_HEXAGON_SDK="${HEXAGON_SDK_ROOT}" \ -DUSE_HEXAGON_TOOLCHAIN="${HEXAGON_TOOLCHAIN}" \ -DUSE_OUTPUT_BINARY_DIR="../../build/hexagon_api_output" \ -DUSE_HEXAGON_GTEST="${HEXAGON_SDK_ROOT}/utils/googletest/gtest" .. make -j2 ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
