gemini-code-assist[bot] commented on PR #18853: URL: https://github.com/apache/tvm/pull/18853#issuecomment-3977220548
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's LLVM dependency by raising the minimum required version to 15.0. This update allowed for a significant cleanup of the codebase, removing numerous conditional compilation blocks and deprecated API usages that were previously maintained for backward compatibility. The primary goal was to simplify maintenance and improve code clarity without introducing any functional changes. ### Highlights * **LLVM Version Bump**: The minimum required LLVM version has been updated from 6.0 to 15.0, aligning the project with more modern compiler infrastructure. * **Codebase Simplification**: Approximately 90 dead `#if TVM_LLVM_VERSION` preprocessor branches have been removed across 15 source files, eliminating 531 lines of compatibility code. * **Configuration and Documentation Updates**: CMake minimum version checks in `FindLLVM.cmake` and `LLVM.cmake` were updated, and documentation references in `from_source.rst` and `config.cmake` were adjusted to reflect the new LLVM requirement. * **No Behavioral Changes**: All changes strictly involve dead-code removal, ensuring no alterations to existing live code paths or project behavior. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **cmake/config.cmake** * Updated the comment indicating the minimum required LLVM version from 4.0 to 15. * **cmake/modules/LLVM.cmake** * Modified the CMake check to enforce a minimum LLVM version of 15.0 instead of 6.0. * **cmake/utils/FindLLVM.cmake** * Adjusted the CMake check to require LLVM 15.0 or higher, previously 4.0. * **docs/install/from_source.rst** * Updated installation instructions to specify LLVM version >= 15. * **src/target/llvm/codegen_aarch64.cc** * Removed conditional compilation blocks related to `TVM_LLVM_VERSION >= 130`. * **src/target/llvm/codegen_amdgpu.cc** * Removed various `TVM_LLVM_VERSION` conditional blocks, simplifying includes and LLVM API calls for `AllocaInst`, `CreateAtomicRMW`, `CloneModule`, and `addPassesToEmitFile`. * **src/target/llvm/codegen_arm.cc** * Removed conditional include for `llvm/IR/IntrinsicsARM.h` based on `TVM_LLVM_VERSION >= 100`. * **src/target/llvm/codegen_blob.cc** * Removed `TVM_LLVM_VERSION` conditional blocks for `llvm/Support/Alignment.h` and `setAlignment` calls. * **src/target/llvm/codegen_cpu.cc** * Removed `TVM_LLVM_VERSION` conditional blocks for debug info creation, alignment settings, `FunctionCallee` usage, and `CreateAlignedLoad` calls. * **src/target/llvm/codegen_hexagon.cc** * Removed `TVM_LLVM_VERSION` conditional blocks for includes, `GetTypeSizeInBits`, `FunctionCallee` usage, intrinsic creation, vector type creation, and `addPassesToEmitFile`. * **src/target/llvm/codegen_llvm.cc** * Removed numerous `TVM_LLVM_VERSION` conditional blocks, simplifying includes, debug info handling, pass manager configuration, vector type creation, alignment, intrinsic declarations, and masked load/store operations. * **src/target/llvm/codegen_llvm.h** * Removed `TVM_LLVM_VERSION` conditional blocks for includes and `GetArg` and `GetVectorNumElements` helper functions. * **src/target/llvm/codegen_nvptx.cc** * Removed `TVM_LLVM_VERSION` conditional blocks for includes, `AllocaInst` alignment, `CreateAtomicRMW` calls, and `addPassesToEmitFile`. * **src/target/llvm/codegen_x86_64.cc** * Removed `TVM_LLVM_VERSION` conditional blocks for includes, `x86_vcvtph2ps_256` intrinsic, and vector type creation. * **src/target/llvm/llvm_instance.cc** * Removed `TVM_LLVM_VERSION` conditional blocks for includes, RISC-V VLEN feature detection, fast math flags, and `LLVMTargetInfo` string representation. * **src/target/llvm/llvm_instance.h** * Removed `TVM_LLVM_VERSION` conditional blocks for includes and `llvmGetIntrinName` macro definition. * **src/target/llvm/llvm_module.cc** * Removed `TVM_LLVM_VERSION` conditional blocks for `llvm_open_output_flag`, `CloneLLVMModule`, `llvm_object_file_target`, `LLVMAddPassesToEmitFile`, `WriteBitcodeToFile`, `InspectSource`, `LLJITBuilder` configuration, and ORCJIT lookup. * **tests/cpp/target/canonicalizer/arm_aprofile_test.cc** * Removed `TVM_LLVM_VERSION` conditional blocks from `CheckArchitectureAvailability` test function. * **tests/cpp/tir_scalable_datatype.cc** * Removed `TVM_LLVM_VERSION` conditional blocks from `TestScalableIntrinCall`. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
