tqchen opened a new pull request, #18854: URL: https://github.com/apache/tvm/pull/18854
## Summary Refactor `docker/bash.sh` incorporating lessons from tdev's `docker/run_container.sh`: - **Auto-detect rootless**: Replace `$DOCKER_IS_ROOTLESS` env var with `docker info` query (env var kept as CI override) - **`--shell <name>`**: New flag to specify interactive shell (e.g., `--shell zsh`) - **`TVM_DEV_MOUNTS`**: New env var for declarative mount configuration (space-separated paths) - **GPU cleanup**: Remove legacy `nvidia-docker` detection and Vulkan ICD mounting; use `--gpus all` - **Code organization**: Extract `detect_rootless()`, `validate_mount()` helpers; organize into labeled sections All existing flags and CI behavior preserved. Backwards compatible. ## Test plan - [x] `bash -n docker/bash.sh` — no syntax errors - [x] `bash docker/bash.sh --help` — shows updated usage - [ ] Manual test in CI-compatible container -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
