gemini-code-assist[bot] commented on code in PR #18860:
URL: https://github.com/apache/tvm/pull/18860#discussion_r2868869790
##########
docker/install/ubuntu_install_sphinx.sh:
##########
@@ -21,13 +21,13 @@ set -u
set -o pipefail
uv pip install \
- autodocsumm==0.2.7 \
+ autodocsumm==0.2.14 \
commonmark==0.9.1 \
- docutils==0.16 \
+ docutils==0.21.2 \
image==1.5.33 \
- matplotlib==3.3.4 \
- sphinx==4.2.0 \
+ matplotlib==3.10.8 \
+ sphinx==8.1.3 \
sphinx_autodoc_annotation~=1.0 \
-
git+https://github.com/sphinx-gallery/sphinx-gallery.git@6142f1791151849b5bec4bf3959f75697ba226cd
\
- sphinx_rtd_theme==1.0.0 \
-
git+https://github.com/tlc-pack/tlcpack-sphinx-addon.git@768ec1dce349fe4708f6ad68be1ebb3f3dabafa1
+ sphinx-gallery==0.20.0 \
+ sphinx_rtd_theme==3.1.0 \
+
git+https://github.com/tlc-pack/tlcpack-sphinx-addon.git@99c6947b05b1ae26ff5003277fb7cff57ce78353
Review Comment:
For better maintainability, consider moving this list of dependencies into a
`requirements.txt` file. This separates the dependencies from the installation
logic, making them easier to manage and update. It also improves visibility of
dependency changes in pull requests.
You could create a `docker/install/sphinx-requirements.txt` file with the
package list:
```text
autodocsumm==0.2.14
commonmark==0.9.1
docutils==0.21.2
image==1.5.33
matplotlib==3.10.8
sphinx==8.1.3
sphinx_autodoc_annotation~=1.0
sphinx-gallery==0.20.0
sphinx_rtd_theme==3.1.0
git+https://github.com/tlc-pack/tlcpack-sphinx-addon.git@99c6947b05b1ae26ff5003277fb7cff57ce78353
```
Then, this script can be simplified.
```suggestion
uv pip install -r docker/install/sphinx-requirements.txt
```
<details>
<summary>References</summary>
1. For better maintainability, Python dependencies should be managed in a
requirements file rather than being listed directly in a script. This separates
configuration from logic and simplifies updates.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
