gemini-code-assist[bot] commented on code in PR #490:
URL: https://github.com/apache/tvm-ffi/pull/490#discussion_r2869134644
##########
python/tvm_ffi/__init__.py:
##########
@@ -111,7 +111,14 @@ def _is_config_mode() -> bool:
float8_e8m0fnu,
float4_e2m1fnx2,
)
+elif sys.platform.startswith("win32"):
+ # On Windows, load the library even in config CLI mode so the DLL search
path
+ # is set correctly (needed in some cases when test still loads cython
extensions).
+ from . import libinfo
+
+ LIB = libinfo.load_lib_ctypes("apache-tvm-ffi", "tvm_ffi", "RTLD_GLOBAL")
Review Comment:
This `elif` block duplicates the library loading code from lines 55-57.
While this change fixes the issue on Windows, the code duplication can make the
code harder to maintain.
To avoid this, you could refactor the conditional logic. The library should
be loaded if not in config mode OR if on Windows. The rest of the
initialization should only happen when not in config mode. This could be
structured as follows:
```python
# Restructure logic around line 40
_do_full_init = TYPE_CHECKING or not _is_config_mode()
_load_library = _do_full_init or sys.platform.startswith("win32")
if _load_library:
from . import libinfo
LIB = libinfo.load_lib_ctypes("apache-tvm-ffi", "tvm_ffi", "RTLD_GLOBAL")
if _do_full_init:
# ... existing imports from the original if-block ...
```
This approach would remove the duplicated code and make the conditions for
initialization more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
