gemini-code-assist[bot] commented on code in PR #510:
URL: https://github.com/apache/tvm-ffi/pull/510#discussion_r2972963172
##########
python/tvm_ffi/_dtype.py:
##########
@@ -63,10 +63,10 @@ class dtype(str):
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
66: import tvm_ffi as ffi
```
##########
python/tvm_ffi/_convert.py:
##########
@@ -58,31 +58,31 @@ def convert(value: Any) -> Any: # noqa: PLR0911,PLR0912
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
61: import tvm_ffi as ffi
```
##########
python/tvm_ffi/container.py:
##########
@@ -452,9 +452,9 @@ class Map(core.Object, Mapping[K, V]):
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
455: import tvm_ffi as ffi
```
##########
python/tvm_ffi/container.py:
##########
@@ -148,9 +148,9 @@ class Array(core.Object, Sequence[T]):
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
151: import tvm_ffi as ffi
```
##########
python/tvm_ffi/libinfo.py:
##########
@@ -17,7 +17,7 @@
"""Utilities to locate tvm_ffi libraries, headers, and helper include paths.
This module also provides helpers to locate and load platform-specific shared
-libraries by a target_name (e.g., ``tvm_ffi`` -> ``libtvm_ffi.so`` on Linux).
Review Comment:
The comment should refer to `libffi.so` instead of `libtvm_ffi.so`.
```suggestion
20:libraries by a target_name (e.g., ``tvm_ffi`` -> ``libffi.so`` on Linux).
```
##########
python/tvm_ffi/libinfo.py:
##########
@@ -49,7 +49,7 @@ def find_libtvm_ffi() -> str:
def find_windows_implib() -> str:
- """Find and return the Windows import library path for tvm_ffi.lib."""
Review Comment:
The docstring should refer to `ffi.lib` instead of `tvm_ffi.lib`.
```python
52: """Find and return the Windows import library path for ffi.lib.
```
##########
python/tvm_ffi/module.py:
##########
@@ -445,7 +445,7 @@ def load_module(path: str | PathLike, keep_module_alive:
bool = True) -> Module:
keep_module_alive
Whether to keep the module alive. If True, the module will be kept
alive
- for the duration of the program until libtvm_ffi.so is unloaded.
Review Comment:
The comment should refer to `libffi.so` instead of `libtvm_ffi.so`.
```suggestion
448: for the duration of the program until libffi.so is unloaded.
```
##########
python/tvm_ffi/_dtype.py:
##########
@@ -160,9 +160,9 @@ def with_lanes(self, lanes: int) -> dtype:
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
163: import tvm_ffi as ffi
```
##########
docs/guides/python_lang_guide.md:
##########
@@ -101,13 +101,13 @@ This is a very powerful pattern that allows us to inject
Python callbacks into t
You can also register a Python callback as a global function.
```python
-import tvm_ffi
+import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
106:@ffi.register_global_func("example.add_one")
```
##########
python/tvm_ffi/_dtype.py:
##########
@@ -195,10 +195,10 @@ def itemsize(self) -> int:
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
198: import tvm_ffi as ffi
```
##########
python/tvm_ffi/error.py:
##########
@@ -225,17 +225,17 @@ def register_error(
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
- # Register a custom Python exception so tvm_ffi.Error maps to it
- @tvm_ffi.error.register_error
+ # Register a custom Python exception so ffi.Error maps to it
+ @ffi.error.register_error
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
232: @ffi.error.register_error
```
##########
python/tvm_ffi/_dtype.py:
##########
@@ -114,11 +114,11 @@ def from_dlpack_data_type(dltype_data_type: tuple[int,
int, int]) -> dtype:
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
117: import tvm_ffi as ffi
```
##########
python/tvm_ffi/_dtype.py:
##########
@@ -220,15 +220,13 @@ def type_code(self) -> int:
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
223: import tvm_ffi as ffi
```
##########
python/tvm_ffi/_tensor.py:
##########
@@ -100,10 +100,10 @@ def device(device_type: str | int | DLDeviceType, index:
int | None = None) -> D
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
103: import tvm_ffi as ffi
```
##########
python/tvm_ffi/_tensor.py:
##########
@@ -48,9 +48,9 @@ class Shape(tuple, PyNativeObject):
.. code-block:: python
import numpy as np
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
51: import tvm_ffi as ffi
```
##########
python/tvm_ffi/cpp/extension.py:
##########
@@ -1018,7 +1018,7 @@ def load_inline( # noqa: PLR0913
'''
# compile the cpp source code and load the module
- mod: Module = tvm_ffi.cpp.load_inline(
+ mod: Module = ffi.cpp.load_inline(
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
1021: mod: Module = ffi.cpp.load_inline(
```
##########
python/tvm_ffi/cpp/extension.py:
##########
@@ -1319,7 +1319,7 @@ def load(
# ```
# compile the cpp source file and load the module
- mod: Module = tvm_ffi.cpp.load(
+ mod: Module = ffi.cpp.load(
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
1322: mod: Module = ffi.cpp.load(
```
##########
python/tvm_ffi/error.py:
##########
@@ -225,17 +225,17 @@ def register_error(
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
228: import tvm_ffi as ffi
```
##########
python/tvm_ffi/container.py:
##########
@@ -560,9 +560,9 @@ class Dict(core.Object, MutableMapping[K, V]):
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
563: import tvm_ffi as ffi
```
##########
python/tvm_ffi/libinfo.py:
##########
@@ -34,7 +34,7 @@
def find_libtvm_ffi() -> str:
- """Find libtvm_ffi.
Review Comment:
The docstring should refer to `libffi` instead of `libtvm_ffi`.
```python
37: """Find libffi.
```
##########
python/tvm_ffi/error.py:
##########
@@ -225,17 +225,17 @@ def register_error(
--------
.. code-block:: python
- import tvm_ffi
+ import tvm_ffi as ffi
- # Register a custom Python exception so tvm_ffi.Error maps to it
- @tvm_ffi.error.register_error
+ # Register a custom Python exception so ffi.Error maps to it
+ @ffi.error.register_error
class MyError(RuntimeError):
pass
# Convert a Python exception to an FFI Error and back
- ffi_err = tvm_ffi.convert(MyError("boom"))
+ ffi_err = ffi.convert(MyError("boom"))
Review Comment:
Consider applying the `ffi` alias directly during import for improved
readability.
```suggestion
238: ffi_err = ffi.convert(MyError("boom"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
