weicheng-hsu commented on PR #19523: URL: https://github.com/apache/tvm/pull/19523#issuecomment-4409651418
Done. Updated the implementation to use consistent 6-element padding, removed redundant comments, and fixed the typo in the error message. Thanks! > ## Code Review > This pull request implements the `CONV_3D` operator in the TFLite frontend for Relax, including the `convert_conv3d` method which handles attribute extraction, layout mapping (NDHWC/DHWIO), and padding calculations. Unit tests for "VALID" and "SAME" padding modes have also been added. The review feedback suggests removing commented-out code, ensuring consistency by using a 6-element padding list for 3D convolutions, and correcting a typo in an error message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
