ConvolutedDog commented on code in PR #19565:
URL: https://github.com/apache/tvm/pull/19565#discussion_r3240425947
##########
tests/python/target/test_target_target.py:
##########
@@ -158,15 +159,19 @@ def test_target_tag_1():
assert tgt.attrs["max_threads_per_block"] == 1024
assert tgt.attrs["thread_warp_size"] == 32
assert tgt.attrs["registers_per_block"] == 32768
+ assert not tgt.attrs["enable_fast_math"]
def test_target_tag_override():
"""Test creating a target from a tag with attribute overrides."""
- tgt = tvm.target.Target({"tag": "nvidia/nvidia-a100",
"l2_cache_size_bytes": 12345})
+ tgt = tvm.target.Target(
+ {"tag": "nvidia/nvidia-a100", "l2_cache_size_bytes": 12345,
"enable_fast_math": True}
+ )
assert tgt.kind.name == "cuda"
assert tgt.attrs["arch"] == "sm_80"
# Override should take effect
assert int(tgt.attrs["l2_cache_size_bytes"]) == 12345
+ assert not tgt.attrs["enable_fast_math"]
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
