mshr-h commented on code in PR #19566:
URL: https://github.com/apache/tvm/pull/19566#discussion_r3252467414
##########
python/tvm/relax/frontend/onnx/onnx_frontend.py:
##########
@@ -72,6 +72,18 @@ def _relax_dtype_is_floating_point(dtype: str) -> bool:
)
+def _const_integer_expr_has_zero(expr: relax.Expr) -> bool | None:
Review Comment:
I don’t think we need to create a new three-line function if it is only
called once from another function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
