Aharrypotter commented on code in PR #19538:
URL: https://github.com/apache/tvm/pull/19538#discussion_r3265095528
##########
python/tvm/relax/frontend/tflite/tflite_frontend.py:
##########
@@ -2600,20 +2510,18 @@ def convert_fully_connected(self, op):
)
weight_expr = self.get_tensor_expr(weight_tensor)
- weight_shape = weight_expr.struct_info.shape
weight_expr = relax.op.permute_dims(weight_expr, [1, 0])
if input_tensor.qnn_params:
- out = _qnn.op.dense(
- in_expr,
+ # Dequantize input and weight (OC remapped from axis 0 to 1)
Review Comment:
Done — added an explicit QuantizedDimension() == 0 check before remapping
the weight quantization axis. Non-zero axes now raise OpAttributeInvalid with
the expected axis in the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
