gemini-code-assist[bot] commented on code in PR #19599:
URL: https://github.com/apache/tvm/pull/19599#discussion_r3296106716
##########
python/tvm/tirx/script/builder/tirx.py:
##########
@@ -34,9 +34,23 @@ def _is_buffer_or_region(x):
return isinstance(x, Buffer | BufferRegion)
-def _to_region(buffer: BufferRegion | Buffer):
+def _is_buffer_region_or_load(x):
+ return isinstance(x, Buffer | BufferRegion | BufferLoad)
+
+
+def _has_tile_call_options(workspace, dispatch, kwargs):
+ return (
+ workspace is not None
+ or dispatch is not None
+ or any(key != "dtype" for key in kwargs.keys())
+ )
+
+
+def _to_region(buffer: BufferRegion | Buffer | BufferLoad):
Review Comment:
The `_to_region` helper function is missing a return type hint. Since it
always returns a `BufferRegion`, adding the hint improves code clarity and IDE
support.
```suggestion
def _to_region(buffer: BufferRegion | Buffer | BufferLoad) -> BufferRegion:
```
##########
python/tvm/tirx/script/builder/tirx.py:
##########
@@ -706,7 +747,7 @@ def reciprocal(
def silu(
dst: BufferRegion | Buffer,
- src: BufferRegion | Buffer,
+ src: BufferRegion | Buffer | None = None,
Review Comment:
The type hints for `dst` and `src` in the `silu` function should be updated
to include `BufferLoad`, consistent with the canonicalization logic implemented
in this PR and the updates to `_to_region`.
```python
def silu(
dst: BufferRegion | Buffer | BufferLoad,
src: BufferRegion | Buffer | BufferLoad | None = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
