gemini-code-assist[bot] commented on code in PR #19600:
URL: https://github.com/apache/tvm/pull/19600#discussion_r3296317693
##########
tests/python/tirx/operator/tile_primitive/cuda/test_copy_async_tma.py:
##########
@@ -1000,6 +1002,7 @@ def _tma_case(
@pytest.mark.parametrize("case", TMA_CASES)
[email protected]_cuda_compute_version(9)
def test_copy_tma_codegen(case):
Review Comment:
This decorator is redundant as the module-level `pytestmark` already
requires CUDA compute version 9 for all tests in this file (line 41).
```suggestion
def test_copy_tma_codegen(case):
```
##########
tests/python/tirx/codegen/test_codegen_hopper.py:
##########
@@ -139,6 +141,7 @@ def func(A: Tx.Buffer((16, 16), "float16")):
@pytest.mark.parametrize("trans", [False, True])
@pytest.mark.parametrize("num", [1, 2, 4])
[email protected]_cuda_compute_version(9)
def test_ptx_stmatrix(trans, num):
Review Comment:
This decorator is redundant because the module-level `pytestmark` already
enforces the requirement for CUDA compute version 9 (line 25). Removing it
keeps the test file cleaner and more maintainable.
```suggestion
def test_ptx_stmatrix(trans, num):
```
##########
tests/python/tirx/operator/tile_primitive/cuda/test_smem_tmem_dispatch.py:
##########
@@ -452,6 +455,7 @@ def kernel(A_ptr: Tx.handle, B_ptr: Tx.handle):
),
],
)
[email protected]_cuda_compute_version(10)
def test_dispatch_rejects_bad_inputs(bad):
Review Comment:
This decorator is redundant because the module-level `pytestmark` already
enforces the requirement for CUDA compute version 10 (line 36).
```suggestion
def test_dispatch_rejects_bad_inputs(bad):
```
##########
tests/python/tirx/operator/tile_primitive/cuda/test_smem_tmem_dispatch.py:
##########
@@ -285,6 +287,7 @@ def _execute(kernel, A_init, expected):
),
],
)
[email protected]_cuda_compute_version(10)
def test_single_cp(name, s_full, s_full_shape, s_region):
Review Comment:
This decorator is redundant because the module-level `pytestmark` already
enforces the requirement for CUDA compute version 10 (line 36).
```suggestion
def test_single_cp(name, s_full, s_full_shape, s_region):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
