gemini-code-assist[bot] commented on code in PR #19602:
URL: https://github.com/apache/tvm/pull/19602#discussion_r3298285451


##########
pyproject.toml:
##########
@@ -182,6 +182,10 @@ addopts = "-v --tb=short"
 python_files = ["test_*.py", "*_test.py"]
 python_classes = ["Test*"]
 python_functions = ["test_*"]
+markers = [
+  "adreno_clml: Mark a test as using adreno_clml",
+  "adreno_opencl_vulkan: Mark a test as using adreno_opencl_vulkan",
+]

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   The registration of markers is incomplete. Based on the features defined in 
`tests/python/relax/backend/adreno/utils.py`, there are other Adreno-specific 
features that will trigger `PytestUnknownMarkWarning` when used. Specifically, 
`adreno_vulkan`, `adreno_opencl`, and `adreno_opencl_real` should also be 
registered to ensure all Adreno test markers are recognized by pytest.
   
   ```
   markers = [
     "adreno_clml: Mark a test as using adreno_clml",
     "adreno_opencl_vulkan: Mark a test as using adreno_opencl_vulkan",
     "adreno_vulkan: Mark a test as using adreno_vulkan",
     "adreno_opencl: Mark a test as using adreno_opencl",
     "adreno_opencl_real: Mark a test as using adreno_opencl_real",
   ]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to