gemini-code-assist[bot] commented on code in PR #19618:
URL: https://github.com/apache/tvm/pull/19618#discussion_r3308201884
##########
python/tvm/tirx/expr.py:
##########
@@ -1303,20 +1303,20 @@ class Call(PrimExprWithOp):
span : Optional[Span]
The location of this expression in the source code.
- annotations : Optional[dict]
- Additional metadata attached to the call.
+ attrs : Optional[tvm.ir.Attrs or dict]
+ Attributes attached to the call.
"""
op: Op
args: list[PrimExpr]
- annotations: dict
+ attrs: ir.Attrs
Review Comment:
Since `attrs` can be `None` (as verified by the test `assert x.attrs is
None` when no attributes are provided), the type annotation for `attrs` should
be `ir.Attrs | None` instead of `ir.Attrs` to ensure correct static type
checking.
```suggestion
attrs: ir.Attrs | None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
