Aharrypotter commented on PR #19639: URL: https://github.com/apache/tvm/pull/19639#issuecomment-4577924478
Hi @tlopex, thanks for the detailed review. I've removed the incorrect `HASHTABLE_FIND` lowering and the synthetic `INT32 -> INT32` / vector-value tests. The hashtable handling is now limited to TFLite's actual kernel constraints: - `HASHTABLE` validates table dtype pairs (`int64 -> string` or `string -> int64`) - `HASHTABLE_IMPORT` is accepted only in `CALL_ONCE` init subgraphs, requires matching key/value dtypes and identical key/value shapes, and records only static metadata (`size`, dtypes) - `HASHTABLE_SIZE` lowers from the recorded metadata - `HASHTABLE_FIND` is rejected with `OpNotImplemented` because correct lowering requires `TensorType.STRING` support in Relax So this PR no longer models hashtables as a generic tensor map. It keeps the resource-variable support plus the safe hashtable metadata/size subset, and leaves real string lookup lowering for a future PR after string tensor support exists. Please take another look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
