tomayac commented on PR #19569: URL: https://github.com/apache/tvm/pull/19569#issuecomment-4593349450
> ⏳ Oh, please wait before merging. I want to test one more thing before. OK, we should be good. All resources that we now additionally cache here use some sort of versioning string in the path of their URLs (e.g, `https://raw.githubusercontent.com/mlc-ai/binary-mlc-llm-libs/main/web-llm-models/v0_2_83/base/Llama-3.2-3B-Instruct-q4f32_1_cs1k-webgpu.wasm`), so we can indeed use the URL as the cache key (`await this.persistHashEntry(url, hash)`) and not be stuck with an outdated version should the resource change. Ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
