tqchen commented on code in PR #19675:
URL: https://github.com/apache/tvm/pull/19675#discussion_r3362282215
##########
include/tvm/arith/int_set.h:
##########
@@ -96,7 +97,7 @@ class IntSet : public ffi::ObjectRef {
* \param ana Analyzer used in the proof.
* \return Whether we can prove it is a single point
*/
- bool CanProveSinglePoint(Analyzer* ana) const;
+ bool CanProveSinglePoint(AnalyzerObj* ana) const;
Review Comment:
This is a user facing API, in such case, we would expect where Analyzer
needs to be passed, likely we would like to switch to const Analyzer& where
analyzer object ref is being passed, and analyzer being mutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
