tqchen opened a new pull request, #607: URL: https://github.com/apache/tvm-ffi/pull/607
[FIX] Drop test_empty_tensor_attributes (numpy dlpack stride change for empty arrays) NumPy silently changed how it exports strides for zero-element arrays via `__dlpack__`. For a shape `(4, 0, 4)` array NumPy previously reported strides `(0, 4, 1)`, but now reports `(0, 0, 0)`. Either choice is arguably valid — any stride values are consistent when the array has zero elements — but `tvm_ffi.from_dlpack` faithfully forwards whatever the upstream exporter provides. The test was asserting a NumPy-side implementation detail that has since changed, so it is removed rather than patched. Deciding what the correct empty-array stride convention should be is a separate question not in scope for this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
