SiriusNEO commented on code in PR #19667: URL: https://github.com/apache/tvm/pull/19667#discussion_r3366754145
########## tests/python/arith/test_arith_z3.py: ########## Review Comment: For the tests, do we need to cover all tests in the original PR?: https://github.com/tile-ai/tilelang/pull/1367/ ########## src/target/z3/z3_prover_off.cc: ########## Review Comment: Using two source files to control `z3_off/z3_on` is a bit strange. Can we use macros to achieve this so that we can merge them into a single `z3_prover.cc`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
