gemini-code-assist[bot] commented on code in PR #19704:
URL: https://github.com/apache/tvm/pull/19704#discussion_r3383738596


##########
tests/python/relax/test_codegen_cublas.py:
##########
@@ -20,6 +20,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



##########
tests/python/relax/test_codegen_cudnn.py:
##########
@@ -20,6 +20,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



##########
tests/python/relax/test_codegen_cutlass.py:
##########
@@ -20,6 +20,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



##########
tests/python/relax/test_codegen_hipblas.py:
##########
@@ -19,6 +19,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



##########
tests/python/relax/test_op_image.py:
##########
@@ -19,6 +19,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



##########
tests/python/relax/test_e2e_op_dynamic.py:
##########
@@ -20,6 +20,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



##########
tests/python/relax/test_op_vision.py:
##########
@@ -20,6 +20,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



##########
tests/python/relax/test_transform_lift_transform_params.py:
##########
@@ -21,6 +21,9 @@
 
 import tvm
 import tvm.testing
+
+pytest.importorskip("scipy")  # tvm.topi.testing imports scipy

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   The module uses `pytest.importorskip` but `pytest` is not imported in this 
file. This will raise a `NameError` during test collection. Please import 
`pytest` explicitly.
   
   ```suggestion
   import pytest
   
   import tvm
   import tvm.testing
   
   pytest.importorskip("scipy")  # tvm.topi.testing imports scipy
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to