gemini-code-assist[bot] commented on code in PR #19735:
URL: https://github.com/apache/tvm/pull/19735#discussion_r3398724986
##########
src/s_tir/transform/inject_permuted_layout.cc:
##########
@@ -268,17 +279,16 @@ class PermutedLayoutInjector : private
IRMutatorWithAnalyzer {
new_call->args.Set(5, new_access_ptr);
new_call->args.Set(6, IntImm(smem_offset->dtype, 0));
return call;
- } else if (call->op.same_as(builtin::mma_store())) {
+ } else if (IsOp(call, builtin::mma_store_legacy(),
"tirx.mma_store_legacy")) {
Review Comment:
Use the pre-retrieved static `Op` for `mma_store_legacy` to avoid string
comparison.
```suggestion
} else if (IsOp(call, builtin::mma_store_legacy(), mma_store_legacy_op))
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
