gemini-code-assist[bot] commented on code in PR #19759: URL: https://github.com/apache/tvm/pull/19759#discussion_r3408880212
########## CMakeLists.txt: ########## @@ -349,7 +349,7 @@ tvm_file_glob(GLOB CODEGEN_SRCS src/backend/trn/codegen/*.cc src/backend/trn/op/*.cc src/backend/trn/transform/*.cc - src/backend/vulkan/codegen/register.cc + src/backend/vulkan/codegen/target_kind.cc Review Comment:  The file `src/target/llvm/intrin_rule_nvptx.cc` has been renamed to `src/backend/cuda/codegen/llvm/intrin_rule_nvptx.cc`. However, because `CMakeLists.txt` only globs `src/backend/cuda/codegen/*.cc` (non-recursively), and `cmake/modules/LLVM.cmake` likely only globs `src/target/llvm/*.cc`, this file is now excluded from the build. To ensure the NVPTX intrinsic rules are compiled, we should add `src/backend/cuda/codegen/llvm/*.cc` to the `CODEGEN_SRCS` list. ``` src/backend/cuda/codegen/llvm/*.cc src/backend/vulkan/codegen/target_kind.cc ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
