gemini-code-assist[bot] commented on code in PR #19760:
URL: https://github.com/apache/tvm/pull/19760#discussion_r3408883433
##########
src/target/llvm/codegen_llvm.cc:
##########
@@ -597,9 +597,8 @@ llvm::Type* CodeGenLLVM::GetLLVMType(const Type& type)
const {
if (auto* ptr = type.as<PrimTypeNode>()) {
return DTypeToLLVMType(ptr->dtype);
} else if (auto* ptr = type.as<PointerTypeNode>()) {
- // LLVM IR doesn't allow void*, nor do we require custom datatypes
- // to have LLVM equivalents, so we need to recognize these
- // patterns explicitly.
+ // LLVM IR doesn't allow void*, so pointer element types that do not
+ // have an LLVM scalar equivalent need explicit handling.
Review Comment:
While updating this comment to reflect the removal of custom datatypes, the
check on line 603 (`primtype->dtype.code() >= DataType::kCustomBegin`) should
also be removed as it is now obsolete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
