MakotoUwu commented on PR #19771: URL: https://github.com/apache/tvm/pull/19771#issuecomment-4716654790
Pushed a small follow-up on head `a2359c159` after rerunning the downstream browser smoke with a WebLLM bundle rebuilt from this PR branch. The smoke first exposed one more scope issue in the chunked path: `this.makeShapeTuple(chunkShape)` can create a cached TVM object on a cache miss, so calling it before `withNewScope(...)` failed with `Must call beginScope to use functions that returns TVM objects`. I moved both CPU and GPU chunk-path `makeShapeTuple` calls inside the existing `withNewScope` callbacks. Local TVM web checks pass on the pushed head: - `git diff --check` - `npm run lint` - `npx tsc --noEmit --pretty false` Downstream Chrome/WebGPU smoke also passes with a WebLLM JS bundle rebuilt against the pushed TVM source: - TVM PR head: `a2359c159cb3fb94766335beea33f281fb9a7bba` - Rebuilt WebLLM bundle SHA256: `c357f887fde2408078e715abe4b7a6b54c719f44d87e4e9ba2cefe58e101e8a5` - TVM `wasm_runtime.bc` SHA256: `8dbe21eeb30abda125e1b71464d16c8cf1f1c877be08c3a1a7275f0a27701a23` - Model wasm used for the smoke: `70d7295dc91b622b79ceeada2c64b4c20787832631c04e3714de95db04515dfc` - Browser: Chrome `149.0.7827.104`, Apple M3 WebGPU/Metal Prompt smoke results: - T1 `Hi`: load `11.6s`, generated `Hi there! How can I help you`, finish `length` - PASS - T2 France one-word answer: load `5.3s`, generated `Paris`, finish `stop` - PASS - T3 haiku: load `5.7s`, generated a non-empty haiku-like response, generation `2.8s`, finish `stop` - PASS Boundary note: this validates the current PR-head TypeScript/WebLLM loading path with the latest available Apache model wasm. It is not a fresh model-wasm rebuild from `a2359c159`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
