gemini-code-assist[bot] commented on code in PR #19872:
URL: https://github.com/apache/tvm/pull/19872#discussion_r3457847412
##########
tests/scripts/ci.py:
##########
@@ -335,23 +334,25 @@ def serve_docs(directory: str = "_docs") -> None:
def lint(interactive: bool = False, fix: bool = False, docker_image: str |
None = None) -> None:
"""
- Run CI's Sanity Check step
+ Run lint checks locally.
arguments:
- interactive -- start a shell after running build / test scripts
- fix -- where possible (currently black and clang-format) edit files in
place with formatting fixes
- docker-image -- manually specify the docker image to use
+ interactive -- start a shell after running build / test scripts when using
--docker-image
+ fix -- where possible edit files in place with formatting fixes
Review Comment:
The `fix` parameter is no longer used anywhere in the `lint` function body.
Since `pre-commit` runs formatting/fixing by default, this parameter has become
redundant.\n\nTo avoid exposing a dead `--fix` option in the CLI, you should
remove `fix` from the function signature and this docstring:\n\n```python\ndef
lint(interactive: bool = False, docker_image: str | None = None) -> None:\n
\"\"\"\n Run lint checks locally.\n\n arguments:\n interactive --
start a shell after running build / test scripts when using --docker-image\n
docker-image -- manually specify a docker image to use\n \"\"\"\n```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
