guan404ming commented on PR #19873: URL: https://github.com/apache/tvm/pull/19873#issuecomment-4811455627
Thanks @tqchen for catching this. Just confirmed it's dead code. With native DLPack bool(8-bit), LLVM lowers bool to byte-addressable i1 and CUDA emits native bool, so the int8 backing isn't needed. Verified end-to-end on LLVM CPU and CUDA L4: bool alloc buffers + load/store + compare/select all pass with the conversion removed. I have updated this PR to just delete the bool→int8 lowering instead of adding the pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
