gemini-code-assist[bot] commented on code in PR #646:
URL: https://github.com/apache/tvm-ffi/pull/646#discussion_r3484037108
##########
include/tvm/ffi/extra/structural_equal.h:
##########
@@ -69,7 +69,7 @@ class StructuralEqual {
* \return True if the two Any values are structurally equal, false
otherwise.
*/
TVM_FFI_INLINE bool operator()(const Any& lhs, const Any& rhs) const {
- return Equal(lhs, rhs, false, true);
+ return Equal(lhs, rhs, false, false);
Review Comment:
Passing multiple consecutive boolean literals (often referred to as the
"Boolean Trap") reduces code readability and increases the risk of parameter
mismatch errors. Since both `map_free_vars` and `skip_tensor_content` default
to `false` in the signature of `Equal`, we can simplify this call to
`Equal(lhs, rhs)` to make the code cleaner and more maintainable.
```c
return Equal(lhs, rhs);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
